[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240821-unbalance-postage-8d232da0ed18@spud>
Date: Wed, 21 Aug 2024 16:51:30 +0100
From: Conor Dooley <conor@...nel.org>
To: Daniel Golle <daniel@...rotopia.org>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
Christian Marangi <ansuelsmth@...il.com>,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
Robert Marko <robimarko@...il.com>,
Russell King <rmk+kernel@...linux.org.uk>,
Chad Monroe <chad.monroe@...ran.com>,
John Crispin <john@...ozen.org>, netdev@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] dt-bindings: net: marvell,aquantia: add
properties to override MDI_CFG
On Wed, Aug 21, 2024 at 01:46:30PM +0100, Daniel Golle wrote:
> Usually the MDI pair order reversal configuration is defined by
> bootstrap pin MDI_CFG. Some designs, however, require overriding the MDI
> pair order and force either normal or reverse order.
Is that a PC way of saying that someone messed up and wired the pins
incorrectly? A concrete example of why this is required would be good ;)
>
> Add properties 'marvell,force-mdi-order-normal' and
> 'marvell,force-mdi-order-reverse' for that purpose.
>
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
> ---
> .../devicetree/bindings/net/marvell,aquantia.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml
> index 9854fab4c4db0..c82d0be48741d 100644
> --- a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml
> +++ b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml
> @@ -48,6 +48,16 @@ properties:
> firmware-name:
> description: specify the name of PHY firmware to load
>
> + marvell,force-mdi-order-normal:
> + type: boolean
> + description:
> + force normal order of MDI pairs, overriding MDI_CFG bootstrap pin.
> +
> + marvell,force-mdi-order-reverse:
> + type: boolean
> + description:
> + force reverse order of MDI pairs, overriding MDI_CFG bootstrap pin.
These properties are mutually exclusive, right? If so, the binding
should enforce that.
Thanks,
Conor.
> +
> nvmem-cells:
> description: phandle to the firmware nvmem cell
> maxItems: 1
> --
> 2.46.0
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists