linux-kernel - Re: [PATCH v3 00/13] uprobes: RCU-protected hot path optimizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4Bzb4YzQ00n9BdJF6VUOPkAj6NG0P5cPcT38ZbMX8HUnFsA@mail.gmail.com>
Date: Wed, 21 Aug 2024 09:41:29 -0700
From: Andrii Nakryiko <andrii.nakryiko@...il.com>
To: peterz@...radead.org
Cc: Andrii Nakryiko <andrii@...nel.org>, linux-trace-kernel@...r.kernel.org, 
	rostedt@...dmis.org, mhiramat@...nel.org, bpf@...r.kernel.org, 
	linux-kernel@...r.kernel.org, jolsa@...nel.org, paulmck@...nel.org, 
	willy@...radead.org, surenb@...gle.com, akpm@...ux-foundation.org, 
	linux-mm@...ck.org, Oleg Nesterov <oleg@...hat.com>
Subject: Re: [PATCH v3 00/13] uprobes: RCU-protected hot path optimizations

On Thu, Aug 15, 2024 at 9:49 AM Andrii Nakryiko
<andrii.nakryiko@...il.com> wrote:
>
> On Thu, Aug 15, 2024 at 6:25 AM Oleg Nesterov <oleg@...hat.com> wrote:
> >
> > On 08/12, Andrii Nakryiko wrote:
> > >
> > > ( In addition to previously posted first 8 patches, I'm sending 5 more as an
> > > RFC for people to get the general gist of where this work heading and what
> > > uprobe performance is now achievable. I think first 8 patches are ready to be
> > > applied and I'd appreciate early feedback on the remaining 5 ones.
> >
> > I didn't read the "RFC" patches yet, will try to do on weekend.
> >
> > As for 1-8, I failed to find any problem:
> > Reviewed-by: Oleg Nesterov <oleg@...hat.com>
> >
>
> Great, thanks a lot for all the thorough reviews you've provided (and
> hopefully will keep providing ;).
>
> Peter, if you don't see any problems with first 8 patches, could you
> please apply them to tip/perf/core some time soon, so that subsequent
> work (SRCU+timeout and, separately, lockless VMA->inode->uprobe
> lookup) can be split into independent pieces and reviewed/landed
> separately? Thanks!

If there are no concerns about the first 8 patches (and Oleg doesn't
have any), it would be nice to apply them. The remaining two sets of
changes are parallelizable in terms of discussion and landing them
independently, so it would help to move the uprobe optimizations works
along nicely. Thank you!