linux-kernel - Re: [PATCH -next 5/5] drm/amd/display: Make dcn35_fpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_NfynxZHrAG8cAhmMmmdMT96kAEZCVB3Tw9jrwqS4rG7w@mail.gmail.com>
Date: Wed, 21 Aug 2024 16:28:18 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: chaitanya.dhere@....com, jun.lei@....com, harry.wentland@....com, 
	sunpeng.li@....com, Rodrigo.Siqueira@....com, alexander.deucher@....com, 
	christian.koenig@....com, Xinhui.Pan@....com, airlied@...il.com, 
	daniel@...ll.ch, alex.hung@....com, aurabindo.pillai@....com, 
	colin.i.king@...il.com, dillon.varone@....com, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 5/5] drm/amd/display: Make dcn35_fpga_funcs static

On Wed, Aug 21, 2024 at 2:33 AM Jinjie Ruan <ruanjinjie@...wei.com> wrote:
>
> The sparse tool complains as follows:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c:1071:22: warning:
>         symbol 'dcn35_fpga_funcs' was not declared. Should it be static?
>
> This symbol is not used outside of dcn35_clk_mgr.c, so marks it static.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>  drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
> index e2d906327e2e..818a9b0933a5 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
> @@ -1068,7 +1068,7 @@ static struct clk_mgr_funcs dcn35_funcs = {
>         .is_ips_supported = dcn35_is_ips_supported,
>  };
>
> -struct clk_mgr_funcs dcn35_fpga_funcs = {
> +static struct clk_mgr_funcs dcn35_fpga_funcs = {
>         .get_dp_ref_clk_frequency = dce12_get_dp_ref_freq_khz,
>         .update_clocks = dcn35_update_clocks_fpga,
>         .init_clocks = dcn35_init_clocks_fpga,

This structure is not used and could be removed.  Making it static
will create a warning.

Alex


> --
> 2.34.1
>