linux-kernel - Re: [PATCH -next 1/5] drm/amd/display: Make core_dcn4_g6_temp_read_blackout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_Of6Up9PinPKrJP9m2LgUUNaFgaJ214DR=09AgSCdeiWg@mail.gmail.com>
Date: Wed, 21 Aug 2024 16:29:37 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: chaitanya.dhere@....com, jun.lei@....com, harry.wentland@....com, 
	sunpeng.li@....com, Rodrigo.Siqueira@....com, alexander.deucher@....com, 
	christian.koenig@....com, Xinhui.Pan@....com, airlied@...il.com, 
	daniel@...ll.ch, alex.hung@....com, aurabindo.pillai@....com, 
	colin.i.king@...il.com, dillon.varone@....com, amd-gfx@...ts.freedesktop.org, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 1/5] drm/amd/display: Make core_dcn4_g6_temp_read_blackout_table
 static

Applied 1-4.

Alex

On Wed, Aug 21, 2024 at 2:33 AM Jinjie Ruan <ruanjinjie@...wei.com> wrote:
>
> The sparse tool complains as follows:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c:6853:56: warning:
>         symbol 'core_dcn4_g6_temp_read_blackout_table' was not declared. Should it be static?
>
> This symbol is not used outside of dml2_core_dcn4_calcs.c, so marks it static.
>
> And not want to change it, so mark it const.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>  .../display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c
> index c3c4d8d9525c..0c24f15d5067 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml2/dml21/src/dml2_core/dml2_core_dcn4_calcs.c
> @@ -6850,7 +6850,8 @@ struct dml2_core_internal_g6_temp_read_blackouts_table {
>         } entries[DML_MAX_CLK_TABLE_SIZE];
>  };
>
> -struct dml2_core_internal_g6_temp_read_blackouts_table core_dcn4_g6_temp_read_blackout_table = {
> +static const struct dml2_core_internal_g6_temp_read_blackouts_table
> +       core_dcn4_g6_temp_read_blackout_table = {
>         .entries = {
>                 {
>                         .uclk_khz = 96000,
> --
> 2.34.1
>