linux-kernel - Re: [PATCH -next 7/8] acpi/ghes: Make cxl_cper_fifo and cxl_cper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66c64de2b476a_1719d2942f@iweiny-mobl.notmuch>
Date: Wed, 21 Aug 2024 15:28:18 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>, <rafael@...nel.org>,
	<lenb@...nel.org>, <james.morse@....com>, <tony.luck@...el.com>,
	<bp@...en8.de>, <ira.weiny@...el.com>, <Jonathan.Cameron@...wei.com>,
	<dan.j.williams@...el.com>, <dave.jiang@...el.com>,
	<u.kleine-koenig@...gutronix.de>, <xueshuai@...ux.alibaba.com>,
	<shiju.jose@...wei.com>, <linux-kernel@...r.kernel.org>,
	<linux-acpi@...r.kernel.org>
CC: <ruanjinjie@...wei.com>
Subject: Re: [PATCH -next 7/8] acpi/ghes: Make cxl_cper_fifo and
 cxl_cper_work static

Jinjie Ruan wrote:
> The sparse tool complains as follows:
> 
> drivers/acpi/apei/ghes.c:681:1: warning:
> 	symbol 'cxl_cper_fifo' was not declared. Should it be static?
> 
> drivers/acpi/apei/ghes.c:685:20: warning:
> 	symbol 'cxl_cper_work' was not declared. Should it be static?
> 
> These symbols are not used outside ghes.c, so marks them static.

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

> 
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>  drivers/acpi/apei/ghes.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index 623cc0cb4a65..df31b3acaf0c 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -678,11 +678,11 @@ static void ghes_defer_non_standard_event(struct acpi_hest_generic_data *gdata,
>  
>  /* Room for 8 entries for each of the 4 event log queues */
>  #define CXL_CPER_FIFO_DEPTH 32
> -DEFINE_KFIFO(cxl_cper_fifo, struct cxl_cper_work_data, CXL_CPER_FIFO_DEPTH);
> +static DEFINE_KFIFO(cxl_cper_fifo, struct cxl_cper_work_data, CXL_CPER_FIFO_DEPTH);
>  
>  /* Synchronize schedule_work() with cxl_cper_work changes */
>  static DEFINE_SPINLOCK(cxl_cper_work_lock);
> -struct work_struct *cxl_cper_work;
> +static struct work_struct *cxl_cper_work;
>  
>  static void cxl_cper_post_event(enum cxl_event_type event_type,
>  				struct cxl_cper_event_rec *rec)
> -- 
> 2.34.1
>