[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240821071100.7839-1-11162571@vivo.com>
Date: Wed, 21 Aug 2024 03:10:58 -0400
From: Yang Ruibin <11162571@...o.com>
To: Martin Tuma <martin.tuma@...iteqautomotive.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com,
Yang Ruibin <11162571@...o.com>
Subject: [PATCH v1] drivers:mgb4:Fix the NULL vs IS_ERR() bug for debugfs_create_dir()
The debugfs_create_dir() function returns error pointers.
It never returns NULL. So use IS_ERR() to check it.
Signed-off-by: Yang Ruibin <11162571@...o.com>
---
drivers/media/pci/mgb4/mgb4_vout.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/pci/mgb4/mgb4_vout.c b/drivers/media/pci/mgb4/mgb4_vout.c
index 998edcbd9723..348c8e01fcbe 100644
--- a/drivers/media/pci/mgb4/mgb4_vout.c
+++ b/drivers/media/pci/mgb4/mgb4_vout.c
@@ -683,7 +683,7 @@ static void debugfs_init(struct mgb4_vout_dev *voutdev)
voutdev->debugfs = debugfs_create_dir(voutdev->vdev.name,
voutdev->mgbdev->debugfs);
- if (!voutdev->debugfs)
+ if (IS_ERR(voutdev->debugfs))
return;
voutdev->regs[0].name = "CONFIG";
--
2.34.1
Powered by blists - more mailing lists