linux-kernel - Re: [PATCH v1] drivers:mgb4:Fix the NULL vs IS_ERR() bug for debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca03a058-c374-44e2-8f44-ccaec8898337@gpxsee.org>
Date: Wed, 21 Aug 2024 10:56:49 +0200
From: Martin Tůma <tumic@...see.org>
To: Yang Ruibin <11162571@...o.com>,
 Martin Tuma <martin.tuma@...iteqautomotive.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers:mgb4:Fix the NULL vs IS_ERR() bug for
 debugfs_create_dir()

On 21. 08. 24 9:10 dop., Yang Ruibin wrote:
> The debugfs_create_dir() function returns error pointers.
> It never returns NULL. So use IS_ERR() to check it.
> 
> Signed-off-by: Yang Ruibin <11162571@...o.com>
> ---
>   drivers/media/pci/mgb4/mgb4_vout.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/mgb4/mgb4_vout.c b/drivers/media/pci/mgb4/mgb4_vout.c
> index 998edcbd9723..348c8e01fcbe 100644
> --- a/drivers/media/pci/mgb4/mgb4_vout.c
> +++ b/drivers/media/pci/mgb4/mgb4_vout.c
> @@ -683,7 +683,7 @@ static void debugfs_init(struct mgb4_vout_dev *voutdev)
>   
>   	voutdev->debugfs = debugfs_create_dir(voutdev->vdev.name,
>   					      voutdev->mgbdev->debugfs);
> -	if (!voutdev->debugfs)
> +	if (IS_ERR(voutdev->debugfs))
>   		return;
>   
>   	voutdev->regs[0].name = "CONFIG";

Reviewed-by: Martin Tůma <martin.tuma@...iteqautomotive.com>