linux-kernel - Re: [tip: x86/urgent] x86/ioremap: Use is_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJrpu5n5ReFCWrtAYsWpneAb+g6hAs4E-NeFh40chJfArEsioQ@mail.gmail.com>
Date: Wed, 21 Aug 2024 11:35:41 +0300
From: Max R <max8rr8@...il.com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: tip-bot2 for Max Ramanouski <tip-bot2@...utronix.de>, linux-tip-commits@...r.kernel.org, 
	Christoph Hellwig <hch@....de>, Alistair Popple <apopple@...dia.com>, x86@...nel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [tip: x86/urgent] x86/ioremap: Use is_ioremap_addr() in iounmap()

Apparently,  x86-32 doesn't provide VMALLOC_START in asm/pgtable.h,
and after a quick glance it seems to be the only arch to do so...
Probably the correct solution is to add include asm/vmalloc.h to
include/linux/ioremap.h, considering it uses VMALLOC_START. Will
resubmit the v4 version of patch later today.

Best regards,
Max


On Tue, 20 Aug 2024 at 23:35, Thomas Gleixner <tglx@...utronix.de> wrote:
>
> On Fri, Aug 16 2024 at 09:43, tip-bot wrote:
> > The following commit has been merged into the x86/urgent branch of tip:
> >
> > Commit-ID:     7b02ad32d83c16abd4961d79f3154b734d1d5d9c
> > Gitweb:        https://git.kernel.org/tip/7b02ad32d83c16abd4961d79f3154b734d1d5d9c
> > Author:        Max Ramanouski <max8rr8@...il.com>
> > AuthorDate:    Thu, 15 Aug 2024 23:56:07 +03:00
> > Committer:     Thomas Gleixner <tglx@...utronix.de>
> > CommitterDate: Fri, 16 Aug 2024 11:33:33 +02:00
> >
> > x86/ioremap: Use is_ioremap_addr() in iounmap()
>
> This has been removed as it fails on a 32-bit defconfig:
>
> include/linux/ioremap.h: In function ‘is_ioremap_addr’:
> include/linux/ioremap.h:14:25: error: ‘VMALLOC_START’ undeclared (first use in this function); did you mean ‘KMALLOC_DMA’?
>    14 | #define IOREMAP_START   VMALLOC_START
>
> Can you please have a look?
>
> Thanks,
>
>         tglx