linux-kernel - Re: [PATCH v4 3/4] arm64: dts: k3-am62a-wakeup: Add R5F device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240821111027.6kx57jftp67ksx52@boxcar>
Date: Wed, 21 Aug 2024 06:10:27 -0500
From: Nishanth Menon <nm@...com>
To: Andrew Davis <afd@...com>
CC: Hari Nagalla <hnagalla@...com>, <vigneshr@...com>, <kristo@...nel.org>,
        <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <conor+dt@...nel.org>, <bb@...com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v4 3/4] arm64: dts: k3-am62a-wakeup: Add R5F device node

On 10:13-20240820, Andrew Davis wrote:
> On 8/20/24 5:40 AM, Hari Nagalla wrote:
> > From: Devarsh Thakkar <devarsht@...com>
> > 
> > AM62A SoCs have a single R5F core in waekup domain. This core is also
> > used as a device manager for the SoC.
> > 
> > Signed-off-by: Devarsh Thakkar <devarsht@...com>
> > Signed-off-by: Hari Nagalla <hnagalla@...com>
> > ---
> >   arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 23 +++++++++++++++++++++
> >   1 file changed, 23 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> > index f5ac101a04df..c4319986e660 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> > @@ -76,6 +76,29 @@ wkup_rti0: watchdog@...00000 {
> >   		status = "reserved";
> >   	};
> > +	wkup_r5fss0: r5fss@...00000 {
> > +		compatible = "ti,am62-r5fss";
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		ranges = <0x78000000 0x00 0x78000000 0x8000>,
> > +			 <0x78100000 0x00 0x78100000 0x8000>;
> > +		power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
> 
> Need newline here.
> 
> > +		wkup_r5fss0_core0: r5f@...00000 {
> > +			compatible = "ti,am62-r5f";
> > +			reg = <0x78000000 0x00008000>,
> > +				<0x78100000 0x00008000>;
> > +			reg-names = "atcm", "btcm";
> > +			ti,sci = <&dmsc>;
> > +			ti,sci-dev-id = <121>;
> > +			ti,sci-proc-ids = <0x01 0xff>;
> > +			resets = <&k3_reset 121 1>;
> > +			firmware-name = "am62-wkup-r5f0_0-fw";
> 
> resets and firmware-name should go before vendor specific properties.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117

> 
> > +			ti,atcm-enable = <1>;
> > +			ti,btcm-enable = <1>;
> > +			ti,loczrama = <1>;
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D