linux-kernel - [PATCH] cpuidle: remove dead code in cpuidle_enter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240821114250.1416421-1-d-gole@ti.com>
Date: Wed, 21 Aug 2024 17:12:50 +0530
From: Dhruva Gole <d-gole@...com>
To: "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano
	<daniel.lezcano@...aro.org>
CC: <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        Kevin Hilman
	<khilman@...libre.com>,
        Markus Schneider-Pargmann <msp@...libre.com>,
        Dhruva
 Gole <d-gole@...com>
Subject: [PATCH] cpuidle: remove dead code in cpuidle_enter_state

Checking for index < 0 is useless because the find_deepest_state
function never really returns a negative value. Since this code hasn't
been reported in over 9 years it's dead code. Hence, remove it.

Signed-off-by: Dhruva Gole <d-gole@...com>
---

Discussions on the original series that added this code:
https://lore.kernel.org/linux-pm/20240821095105.xuf2a5xe3yxqqewj@lcpd911/T/#u

 drivers/cpuidle/cpuidle.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 02e40fd7d948..9e418aec1755 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -228,10 +228,7 @@ noinstr int cpuidle_enter_state(struct cpuidle_device *dev,
 	if (broadcast && tick_broadcast_enter()) {
 		index = find_deepest_state(drv, dev, target_state->exit_latency_ns,
 					   CPUIDLE_FLAG_TIMER_STOP, false);
-		if (index < 0) {
-			default_idle_call();
-			return -EBUSY;
-		}
+
 		target_state = &drv->states[index];
 		broadcast = false;
 	}

base-commit: bb1b0acdcd66e0d8eedee3570d249e076b89ab32
-- 
2.34.1