linux-kernel - Re: [PATCH] cpuidle: remove dead code in cpuidle_enter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gVE=05+Yp9rVg55oFQdPQoooKYOeJmr5_-u238x0b8jg@mail.gmail.com>
Date: Thu, 22 Aug 2024 21:06:25 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Dhruva Gole <d-gole@...com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, 
	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, 
	Kevin Hilman <khilman@...libre.com>, Markus Schneider-Pargmann <msp@...libre.com>
Subject: Re: [PATCH] cpuidle: remove dead code in cpuidle_enter_state

On Wed, Aug 21, 2024 at 1:43 PM Dhruva Gole <d-gole@...com> wrote:
>
> Checking for index < 0 is useless because the find_deepest_state
> function never really returns a negative value. Since this code hasn't
> been reported in over 9 years it's dead code. Hence, remove it.
>
> Signed-off-by: Dhruva Gole <d-gole@...com>
> ---
>
> Discussions on the original series that added this code:
> https://lore.kernel.org/linux-pm/20240821095105.xuf2a5xe3yxqqewj@lcpd911/T/#u
>
>  drivers/cpuidle/cpuidle.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index 02e40fd7d948..9e418aec1755 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -228,10 +228,7 @@ noinstr int cpuidle_enter_state(struct cpuidle_device *dev,
>         if (broadcast && tick_broadcast_enter()) {
>                 index = find_deepest_state(drv, dev, target_state->exit_latency_ns,
>                                            CPUIDLE_FLAG_TIMER_STOP, false);
> -               if (index < 0) {
> -                       default_idle_call();
> -                       return -EBUSY;
> -               }
> +
>                 target_state = &drv->states[index];
>                 broadcast = false;
>         }
>

Applied as 6.12 material, thanks!