linux-kernel - Re: [PATCH] x86/MCE: Prevent CPU offline for SMCA CPUs with non-core banks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240822141432.GA211090@yaz-khff2.amd.com>
Date: Thu, 22 Aug 2024 10:14:32 -0400
From: Yazen Ghannam <yazen.ghannam@....com>
To: boris.ostrovsky@...cle.com
Cc: linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	tony.luck@...el.com, x86@...nel.org, avadhut.naik@....com,
	john.allen@....com
Subject: Re: [PATCH] x86/MCE: Prevent CPU offline for SMCA CPUs with non-core
 banks

On Wed, Aug 21, 2024 at 02:35:23PM -0400, boris.ostrovsky@...cle.com wrote:
> 
> 
> On 8/21/24 10:00 AM, Yazen Ghannam wrote:
> 
> > +	if (!mce_cpu_is_hotpluggable()) {
> > +		pr_info("CPU%d is not hotpluggable\n", cpu);
> 
> Can this error message be made a little more informative, e.g. that it is
> emitted from MCA code? And is info the right level? I think notice would be
> more appropriate.
>

Sure thing. I can change the level to notice.

The MCE subsystem has a global prefix set already by pr_fmt. This is
defined in arch/x86/kernel/cpu/mce/internal.h.

Thanks,
Yazen