| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202408222119.6YF3UR6O-lkp@intel.com>
Date: Thu, 22 Aug 2024 22:14:25 +0800
From: kernel test robot <lkp@...el.com>
To: Steven Price <steven.price@....com>, kvm@...r.kernel.org,
kvmarm@...ts.linux.dev
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
Steven Price <steven.price@....com>,
Catalin Marinas <catalin.marinas@....com>,
Marc Zyngier <maz@...nel.org>, Will Deacon <will@...nel.org>,
James Morse <james.morse@....com>,
Oliver Upton <oliver.upton@...ux.dev>,
Suzuki K Poulose <suzuki.poulose@....com>,
Zenghui Yu <yuzenghui@...wei.com>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Joey Gouly <joey.gouly@....com>,
Alexandru Elisei <alexandru.elisei@....com>,
Christoffer Dall <christoffer.dall@....com>,
Fuad Tabba <tabba@...gle.com>, linux-coco@...ts.linux.dev,
Ganapatrao Kulkarni <gankulkarni@...amperecomputing.com>,
Gavin Shan <gshan@...hat.com>,
Shanker Donthineni <sdonthineni@...dia.com>,
Alper Gun <alpergun@...gle.com>
Subject: Re: [PATCH v4 18/43] arm64: RME: Handle realm enter/exit
Hi Steven,
kernel test robot noticed the following build warnings:
[auto build test WARNING on kvmarm/next]
[also build test WARNING on kvm/queue arm64/for-next/core linus/master v6.11-rc4 next-20240822]
[cannot apply to kvm/linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Steven-Price/KVM-Prepare-for-handling-only-shared-mappings-in-mmu_notifier-events/20240821-235327
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next
patch link: https://lore.kernel.org/r/20240821153844.60084-19-steven.price%40arm.com
patch subject: [PATCH v4 18/43] arm64: RME: Handle realm enter/exit
config: arm64-allmodconfig (https://download.01.org/0day-ci/archive/20240822/202408222119.6YF3UR6O-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 26670e7fa4f032a019d23d56c6a02926e854e8af)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240822/202408222119.6YF3UR6O-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408222119.6YF3UR6O-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from arch/arm64/kvm/rme-exit.c:6:
In file included from include/linux/kvm_host.h:16:
In file included from include/linux/mm.h:2228:
include/linux/vmstat.h:500:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
500 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
501 | item];
| ~~~~
include/linux/vmstat.h:507:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
507 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
508 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
514 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
include/linux/vmstat.h:519:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
519 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
520 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:528:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
528 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
529 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/rme-exit.c:61:23: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
61 | [ESR_ELx_EC_SYS64] = rec_exit_sys_reg,
| ^~~~~~~~~~~~~~~~
arch/arm64/kvm/rme-exit.c:60:27: note: previous initialization is here
60 | [0 ... ESR_ELx_EC_MAX] = rec_exit_reason_notimpl,
| ^~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/rme-exit.c:62:26: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
62 | [ESR_ELx_EC_DABT_LOW] = rec_exit_sync_dabt,
| ^~~~~~~~~~~~~~~~~~
arch/arm64/kvm/rme-exit.c:60:27: note: previous initialization is here
60 | [0 ... ESR_ELx_EC_MAX] = rec_exit_reason_notimpl,
| ^~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/rme-exit.c:63:26: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
63 | [ESR_ELx_EC_IABT_LOW] = rec_exit_sync_iabt
| ^~~~~~~~~~~~~~~~~~
arch/arm64/kvm/rme-exit.c:60:27: note: previous initialization is here
60 | [0 ... ESR_ELx_EC_MAX] = rec_exit_reason_notimpl,
| ^~~~~~~~~~~~~~~~~~~~~~~
>> arch/arm64/kvm/rme-exit.c:94:6: warning: variable 'top_ipa' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
94 | if (realm_is_addr_protected(realm, base) &&
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
95 | realm_is_addr_protected(realm, top - 1)) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/rme-exit.c:108:44: note: uninitialized use occurs here
108 | kvm_prepare_memory_fault_exit(vcpu, base, top_ipa - base, false, false,
| ^~~~~~~
arch/arm64/kvm/rme-exit.c:94:2: note: remove the 'if' if its condition is always true
94 | if (realm_is_addr_protected(realm, base) &&
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
95 | realm_is_addr_protected(realm, top - 1)) {
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> arch/arm64/kvm/rme-exit.c:94:6: warning: variable 'top_ipa' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized]
94 | if (realm_is_addr_protected(realm, base) &&
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/rme-exit.c:108:44: note: uninitialized use occurs here
108 | kvm_prepare_memory_fault_exit(vcpu, base, top_ipa - base, false, false,
| ^~~~~~~
arch/arm64/kvm/rme-exit.c:94:6: note: remove the '&&' if its condition is always true
94 | if (realm_is_addr_protected(realm, base) &&
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm64/kvm/rme-exit.c:91:23: note: initialize the variable 'top_ipa' to silence this warning
91 | unsigned long top_ipa;
| ^
| = 0
10 warnings generated.
vim +94 arch/arm64/kvm/rme-exit.c
58
59 static exit_handler_fn rec_exit_handlers[] = {
> 60 [0 ... ESR_ELx_EC_MAX] = rec_exit_reason_notimpl,
61 [ESR_ELx_EC_SYS64] = rec_exit_sys_reg,
62 [ESR_ELx_EC_DABT_LOW] = rec_exit_sync_dabt,
63 [ESR_ELx_EC_IABT_LOW] = rec_exit_sync_iabt
64 };
65
66 static int rec_exit_psci(struct kvm_vcpu *vcpu)
67 {
68 struct realm_rec *rec = &vcpu->arch.rec;
69 int i;
70 int ret;
71
72 for (i = 0; i < REC_RUN_GPRS; i++)
73 vcpu_set_reg(vcpu, i, rec->run->exit.gprs[i]);
74
75 ret = kvm_smccc_call_handler(vcpu);
76
77 for (i = 0; i < REC_RUN_GPRS; i++)
78 rec->run->enter.gprs[i] = vcpu_get_reg(vcpu, i);
79
80 return ret;
81 }
82
83 static int rec_exit_ripas_change(struct kvm_vcpu *vcpu)
84 {
85 struct kvm *kvm = vcpu->kvm;
86 struct realm *realm = &kvm->arch.realm;
87 struct realm_rec *rec = &vcpu->arch.rec;
88 unsigned long base = rec->run->exit.ripas_base;
89 unsigned long top = rec->run->exit.ripas_top;
90 unsigned long ripas = rec->run->exit.ripas_value & 1;
91 unsigned long top_ipa;
92 int ret = -EINVAL;
93
> 94 if (realm_is_addr_protected(realm, base) &&
95 realm_is_addr_protected(realm, top - 1)) {
96 kvm_mmu_topup_memory_cache(&vcpu->arch.mmu_page_cache,
97 kvm_mmu_cache_min_pages(vcpu->arch.hw_mmu));
98 write_lock(&kvm->mmu_lock);
99 ret = realm_set_ipa_state(vcpu, base, top, ripas, &top_ipa);
100 write_unlock(&kvm->mmu_lock);
101 }
102
103 WARN(ret && ret != -ENOMEM,
104 "Unable to satisfy SET_IPAS for %#lx - %#lx, ripas: %#lx\n",
105 base, top, ripas);
106
107 /* Exit to VMM to complete the change */
> 108 kvm_prepare_memory_fault_exit(vcpu, base, top_ipa - base, false, false,
109 ripas == 1);
110
111 return 0;
112 }
113
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists