linux-kernel - Re: [v2] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALTg27kV7px7TQ0nQuEUPHEqXFxsi3ieXekZK1Ze_oVkWEVjSg@mail.gmail.com>
Date: Thu, 22 Aug 2024 16:36:46 +0100
From: Stuart <stuart.a.hayhurst@...il.com>
To: Jiri Kosina <jikos@...nel.org>
Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>, Markus Elfring <Markus.Elfring@....de>, 
	linux-input@...r.kernel.org, kernel-janitors@...r.kernel.org, 
	LKML <linux-kernel@...r.kernel.org>, Benjamin Tissoires <bentiss@...nel.org>
Subject: Re: [v2] HID: corsair-void: Add Corsair Void headset family driver

On Thu, Aug 22, 2024 at 12:57 PM Jiri Kosina <jikos@...nel.org> wrote:

> > > If I recollect correctly, there may be an alignment issue and just using
> > > the stack is not enough to guaranty what is needed.
> >
> > I can't find any reference to issues with it, I'm not sure what I saw before.
> > Also, it seems like the hid-asus driver is using it:
> > https://elixir.bootlin.com/linux/v6.11-rc4/source/drivers/hid/hid-asus.c#L391
>
> You can't do DMA from stack; see section "What memory is DMA'able?" of
> Documentation/core-api/dma-api-howto.rst

Thanks for the link, I knew I'd seen something somewhere,
I'll leave the allocation as-is then

Stuart