linux-kernel - Re: [v2] HID: corsair-void: Add Corsair Void headset family driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2408221355360.12664@cbobk.fhfr.pm>
Date: Thu, 22 Aug 2024 13:57:21 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: Stuart <stuart.a.hayhurst@...il.com>
cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>, 
    Markus Elfring <Markus.Elfring@....de>, linux-input@...r.kernel.org, 
    kernel-janitors@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, 
    Benjamin Tissoires <bentiss@...nel.org>
Subject: Re: [v2] HID: corsair-void: Add Corsair Void headset family driver

On Thu, 22 Aug 2024, Stuart wrote:

> > If I recollect correctly, there may be an alignment issue and just using
> > the stack is not enough to guaranty what is needed.
> 
> I can't find any reference to issues with it, I'm not sure what I saw before.
> Also, it seems like the hid-asus driver is using it:
> https://elixir.bootlin.com/linux/v6.11-rc4/source/drivers/hid/hid-asus.c#L391

You can't do DMA from stack; see section "What memory is DMA'able?" of 
Documentation/core-api/dma-api-howto.rst

-- 
Jiri Kosina
SUSE Labs