linux-kernel - Re: [PATCH -next v2 RESEND] drm/amd/display: Remove unused dcn35_fpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADnq5_Pm9GHaFWLUniQ608CNMPMSBpNdh2JW9-AcKyEM18KE9Q@mail.gmail.com>
Date: Thu, 22 Aug 2024 14:01:07 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: harry.wentland@....com, sunpeng.li@....com, Rodrigo.Siqueira@....com, 
	alexander.deucher@....com, christian.koenig@....com, Xinhui.Pan@....com, 
	airlied@...il.com, daniel@...ll.ch, nicholas.kazlauskas@....com, 
	Charlene.Liu@....com, chiahsuan.chung@....com, hamza.mahfooz@....com, 
	sungjoon.kim@....com, syed.hassan@....com, roman.li@....com, 
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next v2 RESEND] drm/amd/display: Remove unused dcn35_fpga_funcs

On Thu, Aug 22, 2024 at 5:20 AM Jinjie Ruan <ruanjinjie@...wei.com> wrote:
>
> dcn35_fpga_funcs is not used anywhere, remove it.

This will lead to warnings about unused functions.  The fpga specific
functions should be removed as well.  I'd suggest compile testing your
changes first to catch these types of warnings.

Alex


>
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
> v2:
> - Remove it instead of making it static.
> ---
>  .../gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c   | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
> index e2d906327e2e..15977c2d256d 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn35/dcn35_clk_mgr.c
> @@ -1068,13 +1068,6 @@ static struct clk_mgr_funcs dcn35_funcs = {
>         .is_ips_supported = dcn35_is_ips_supported,
>  };
>
> -struct clk_mgr_funcs dcn35_fpga_funcs = {
> -       .get_dp_ref_clk_frequency = dce12_get_dp_ref_freq_khz,
> -       .update_clocks = dcn35_update_clocks_fpga,
> -       .init_clocks = dcn35_init_clocks_fpga,
> -       .get_dtb_ref_clk_frequency = dcn31_get_dtb_ref_freq_khz,
> -};
> -
>  void dcn35_clk_mgr_construct(
>                 struct dc_context *ctx,
>                 struct clk_mgr_dcn35 *clk_mgr,
> --
> 2.34.1
>