linux-kernel - Re: [PATCH v1] drivers/pinctrl/renesas: Switch to use kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZsipPZz7O0yrOHE9@black.fi.intel.com>
Date: Fri, 23 Aug 2024 18:22:37 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Shen Lichuan <shenlichuan@...o.com>
Cc: geert+renesas@...der.be, linus.walleij@...aro.org,
	linux-renesas-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers/pinctrl/renesas: Switch to use kmemdup_array()

On Thu, Aug 22, 2024 at 02:14:38PM +0800, Shen Lichuan wrote:
> Let the kememdup_array() take care about
> multiplication and possible overflows.

> +	cfgs = kmemdup_array(configs, num_configs,
> +				sizeof(*cfgs), GFP_KERNEL);

Geert, don't you want to fix the indentation issues?
Perhaps even combining these to a single line?

...

> +	cfgs = kmemdup_array(configs, num_configs,
> +				sizeof(*cfgs), GFP_KERNEL);
>  	if (!cfgs)
>  		return -ENOMEM;

Ditto.

...

> +	cfgs = kmemdup_array(configs, num_configs,
> +				sizeof(*cfgs), GFP_KERNEL);

Ditto.

-- 
With Best Regards,
Andy Shevchenko