linux-kernel - Re: [PATCH v1] drivers/pinctrl/renesas: Switch to use kmemdup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdX=T04FizyGQ4QBWYw_Ug8ODg6K+dQ=Cqg8L7pmA6wEDg@mail.gmail.com>
Date: Fri, 23 Aug 2024 17:30:06 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Shen Lichuan <shenlichuan@...o.com>, linus.walleij@...aro.org, 
	linux-renesas-soc@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, opensource.kernel@...o.com
Subject: Re: [PATCH v1] drivers/pinctrl/renesas: Switch to use kmemdup_array()

Hi Andy,

On Fri, Aug 23, 2024 at 5:22 PM Andy Shevchenko
<andriy.shevchenko@...el.com> wrote:
> On Thu, Aug 22, 2024 at 02:14:38PM +0800, Shen Lichuan wrote:
> > Let the kememdup_array() take care about
> > multiplication and possible overflows.
>
> > +     cfgs = kmemdup_array(configs, num_configs,
> > +                             sizeof(*cfgs), GFP_KERNEL);
>
> Geert, don't you want to fix the indentation issues?
> Perhaps even combining these to a single line?

I have already done so while applying ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds