linux-kernel - Re: [PATCH 4/7] staging: vchiq_core: Factor out bulk transfer for (no/)callback mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <08aa277d-a966-4785-921e-6a63a2e5922b@app.fastmail.com>
Date: Fri, 23 Aug 2024 15:41:00 +0000
From: "Arnd Bergmann" <arnd@...db.de>
To: "Umang Jain" <umang.jain@...asonboard.com>,
 "Florian Fainelli" <florian.fainelli@...adcom.com>,
 "Broadcom internal kernel review list" <bcm-kernel-feedback-list@...adcom.com>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc: linux-rpi-kernel@...ts.infradead.org,
 linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org, "Dan Carpenter" <dan.carpenter@...aro.org>,
 "laurent.pinchart" <laurent.pinchart@...asonboard.com>,
 "Kieran Bingham" <kieran.bingham@...asonboard.com>,
 "Stefan Wahren" <wahrenst@....net>,
 "Dave Stevenson" <dave.stevenson@...pberrypi.com>,
 "Phil Elwell" <phil@...pberrypi.com>
Subject: Re: [PATCH 4/7] staging: vchiq_core: Factor out bulk transfer for
 (no/)callback mode

On Fri, Aug 23, 2024, at 15:14, Umang Jain wrote:

> 
> +int
> +bulk_xfer_callback_interruptible(struct vchiq_instance *instance, 
> unsigned int handle,
> +				 void *offset, void __user *uoffset, int size,
> +				 enum vchiq_bulk_mode mode, void *userdata,
> +				 enum vchiq_bulk_dir dir)

It seems you can also tighten the argument types here a bit more:

- uoffset is always NULL and can be left out
- userdata is either NULL or a struct mmal_msg_context, so you can use
  that type directly.

     Arnd