[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240823062535.3073706-1-billy_tsai@aspeedtech.com>
Date: Fri, 23 Aug 2024 14:25:35 +0800
From: Billy Tsai <billy_tsai@...eedtech.com>
To: <alexandre.belloni@...tlin.com>, <jarkko.nikula@...ux.intel.com>,
<billy_tsai@...eedtech.com>, <linux-i3c@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>
Subject: [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure
The exit criteria for the DAA should check if the data length is equal to
1, instead of checking if the response status is equal to 1.
Signed-off-by: Billy Tsai <billy_tsai@...eedtech.com>
---
drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
index d97c3175e0e2..6a781f89b0e4 100644
--- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
+++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
@@ -339,7 +339,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
break;
}
if (RESP_STATUS(xfer[0].response) == RESP_ERR_NACK &&
- RESP_STATUS(xfer[0].response) == 1) {
+ RESP_DATA_LENGTH(xfer->response) == 1) {
ret = 0; /* no more devices to be assigned */
break;
}
--
2.25.1
Powered by blists - more mailing lists