linux-kernel - Re: [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <473d838e-7b19-46b7-99a1-73fb8037188b@linux.intel.com>
Date: Fri, 23 Aug 2024 15:48:09 +0300
From: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To: Billy Tsai <billy_tsai@...eedtech.com>, alexandre.belloni@...tlin.com,
 linux-i3c@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa
 procedure

Hi

On 8/23/24 9:25 AM, Billy Tsai wrote:
> The exit criteria for the DAA should check if the data length is equal to
> 1, instead of checking if the response status is equal to 1.
> 
> Signed-off-by: Billy Tsai <billy_tsai@...eedtech.com>
> ---
>   drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> index d97c3175e0e2..6a781f89b0e4 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> @@ -339,7 +339,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
>   			break;
>   		}
>   		if (RESP_STATUS(xfer[0].response) == RESP_ERR_NACK &&
> -		    RESP_STATUS(xfer[0].response) == 1) {
> +		    RESP_DATA_LENGTH(xfer->response) == 1) {
>   			ret = 0;  /* no more devices to be assigned */
>   			break;
>   		}
Did you accidentally resend this from a local tree? Is this the same 
than your commit cbf871e6d8ce ("i3c/master: cmd_v1: Fix the exit 
criteria for the daa procedure")?