linux-kernel - RE: [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <OSQPR06MB7252933AEDE847FB2C31FB1F8B8B2@OSQPR06MB7252.apcprd06.prod.outlook.com>
Date: Mon, 26 Aug 2024 03:37:09 +0000
From: Billy Tsai <billy_tsai@...eedtech.com>
To: Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
	"alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
	"linux-i3c@...ts.infradead.org" <linux-i3c@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa
 procedure

> > The exit criteria for the DAA should check if the data length is equal to
> > 1, instead of checking if the response status is equal to 1.
> >
> > Signed-off-by: Billy Tsai <billy_tsai@...eedtech.com>
> > ---
> >   drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> > index d97c3175e0e2..6a781f89b0e4 100644
> > --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> > +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> > @@ -339,7 +339,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
> >                        break;
> >                }
> >                if (RESP_STATUS(xfer[0].response) == RESP_ERR_NACK &&
> > -                 RESP_STATUS(xfer[0].response) == 1) {
> > +                 RESP_DATA_LENGTH(xfer->response) == 1) {
> >                        ret = 0;  /* no more devices to be assigned */
> >                        break;
> >                }
> Did you accidentally resend this from a local tree? Is this the same
> than your commit cbf871e6d8ce ("i3c/master: cmd_v1: Fix the exit
> criteria for the daa procedure")?

Sorry,  I have re-sent the previous patch from my local machine.