linux-kernel - Re: [PATCH v2 08/36] soc: fsl: cpm1: tsa: Remove unused registers offset definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <787d893d-2898-49e2-b0dd-f23a1b7186fe@csgroup.eu>
Date: Fri, 23 Aug 2024 10:05:39 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Herve Codina <herve.codina@...tlin.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Qiang Zhao <qiang.zhao@....com>,
 Li Yang <leoyang.li@....com>, Mark Brown <broonie@...nel.org>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 08/36] soc: fsl: cpm1: tsa: Remove unused registers
 offset definition



Le 08/08/2024 à 09:11, Herve Codina a écrit :
> SISTR, SICMR and SIRP registers offset definitions are not used.
> 
> In order to avoid unneeded code, remove them.
> 
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>


> ---
>   drivers/soc/fsl/qe/tsa.c | 9 ---------
>   1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/soc/fsl/qe/tsa.c b/drivers/soc/fsl/qe/tsa.c
> index a9d35b44489d..244d521d8780 100644
> --- a/drivers/soc/fsl/qe/tsa.c
> +++ b/drivers/soc/fsl/qe/tsa.c
> @@ -66,12 +66,6 @@
>   #define   TSA_SIGMR_RDM_STATIC_TDMAB	FIELD_PREP_CONST(TSA_SIGMR_RDM_MASK, 0x2)
>   #define   TSA_SIGMR_RDM_DYN_TDMAB	FIELD_PREP_CONST(TSA_SIGMR_RDM_MASK, 0x3)
>   
> -/* SI status register (8 bits) */
> -#define TSA_SISTR	0x06
> -
> -/* SI command register (8 bits) */
> -#define TSA_SICMR	0x07
> -
>   /* SI clock route register (32 bits) */
>   #define TSA_SICR	0x0C
>   #define   TSA_SICR_SCC2_MASK		GENMASK(15, 8)
> @@ -102,9 +96,6 @@
>   #define       TSA_SICR_SCC_TXCS_CLK37	FIELD_PREP_CONST(TSA_SICR_SCC_TXCS_MASK, 0x6)
>   #define       TSA_SICR_SCC_TXCS_CLK48	FIELD_PREP_CONST(TSA_SICR_SCC_TXCS_MASK, 0x7)
>   
> -/* Serial interface RAM pointer register (32 bits) */
> -#define TSA_SIRP	0x10
> -
>   struct tsa_entries_area {
>   	void __iomem *entries_start;
>   	void __iomem *entries_next;