linux-kernel - Re: [PATCH v2 09/36] soc: fsl: cpm1: tsa: Use ARRAY_SIZE() instead of hardcoded integer values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e217798f-af3b-464b-be6d-ea94668766b5@csgroup.eu>
Date: Fri, 23 Aug 2024 10:05:59 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Herve Codina <herve.codina@...tlin.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Qiang Zhao <qiang.zhao@....com>,
 Li Yang <leoyang.li@....com>, Mark Brown <broonie@...nel.org>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 09/36] soc: fsl: cpm1: tsa: Use ARRAY_SIZE() instead of
 hardcoded integer values



Le 08/08/2024 à 09:11, Herve Codina a écrit :
> Loops handling the tdm array use hardcoded size and the initialization
> part uses hardcoded indexes to initialize the array.
> 
> Use ARRAY_SIZE() to avoid the hardcoded size and initialize the array
> using a loop.
> 
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>


> ---
>   drivers/soc/fsl/qe/tsa.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/soc/fsl/qe/tsa.c b/drivers/soc/fsl/qe/tsa.c
> index 244d521d8780..3d0c31a62dbb 100644
> --- a/drivers/soc/fsl/qe/tsa.c
> +++ b/drivers/soc/fsl/qe/tsa.c
> @@ -448,8 +448,8 @@ static int tsa_of_parse_tdms(struct tsa *tsa, struct device_node *np)
>   	int i;
>   
>   	tsa->tdms = 0;
> -	tsa->tdm[0].is_enable = false;
> -	tsa->tdm[1].is_enable = false;
> +	for (i = 0; i < ARRAY_SIZE(tsa->tdm); i++)
> +		tsa->tdm[i].is_enable = false;
>   
>   	for_each_available_child_of_node(np, tdm_np) {
>   		ret = of_property_read_u32(tdm_np, "reg", &tdm_id);
> @@ -609,7 +609,7 @@ static int tsa_of_parse_tdms(struct tsa *tsa, struct device_node *np)
>   	return 0;
>   
>   err:
> -	for (i = 0; i < 2; i++) {
> +	for (i = 0; i < ARRAY_SIZE(tsa->tdm); i++) {
>   		if (tsa->tdm[i].l1rsync_clk) {
>   			clk_disable_unprepare(tsa->tdm[i].l1rsync_clk);
>   			clk_put(tsa->tdm[i].l1rsync_clk);
> @@ -710,7 +710,7 @@ static void tsa_remove(struct platform_device *pdev)
>   	struct tsa *tsa = platform_get_drvdata(pdev);
>   	int i;
>   
> -	for (i = 0; i < 2; i++) {
> +	for (i = 0; i < ARRAY_SIZE(tsa->tdm); i++) {
>   		if (tsa->tdm[i].l1rsync_clk) {
>   			clk_disable_unprepare(tsa->tdm[i].l1rsync_clk);
>   			clk_put(tsa->tdm[i].l1rsync_clk);