linux-kernel - Re: [PATCH v2 29/36] soc: fsl: cpm1: qmc: Handle RPACK initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58da9d56-4642-409c-9375-1f0b28ce2af7@csgroup.eu>
Date: Fri, 23 Aug 2024 10:13:11 +0200
From: Christophe Leroy <christophe.leroy@...roup.eu>
To: Herve Codina <herve.codina@...tlin.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Qiang Zhao <qiang.zhao@....com>,
 Li Yang <leoyang.li@....com>, Mark Brown <broonie@...nel.org>
Cc: linuxppc-dev@...ts.ozlabs.org, linux-arm-kernel@...ts.infradead.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v2 29/36] soc: fsl: cpm1: qmc: Handle RPACK initialization



Le 08/08/2024 à 09:11, Herve Codina a écrit :
> Current code handles the CPM1 version of QMC, RPACK does not need to
> be initialized. This is not the case in the QUICC Engine (QE) version.
> 
> In preparation of the support for QE, initialize the RPACK register
> when the receiver is initialized and each time it is restarted.
> 
> This additional RPACK initialization has no impact in the CPM1 version
> of QMC.
> 
> Signed-off-by: Herve Codina <herve.codina@...tlin.com>

Reviewed-by: Christophe Leroy <christophe.leroy@...roup.eu>

> ---
>   drivers/soc/fsl/qe/qmc.c | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
> index 272da250a763..63af2608c3cd 100644
> --- a/drivers/soc/fsl/qe/qmc.c
> +++ b/drivers/soc/fsl/qe/qmc.c
> @@ -221,6 +221,7 @@ struct qmc_data {
>   	u32 zistate; /* Initial ZISTATE value */
>   	u32 zdstate_hdlc; /* Initial ZDSTATE value (HDLC mode) */
>   	u32 zdstate_transp; /* Initial ZDSTATE value (Transparent mode) */
> +	u32 rpack; /* Initial RPACK value */
>   };
>   
>   struct qmc {
> @@ -552,6 +553,7 @@ int qmc_chan_read_submit(struct qmc_chan *chan, dma_addr_t addr, size_t length,
>   	/* Restart receiver if needed */
>   	if (chan->is_rx_halted && !chan->is_rx_stopped) {
>   		/* Restart receiver */
> +		qmc_write32(chan->s_param + QMC_SPE_RPACK, chan->qmc->data->rpack);
>   		qmc_write32(chan->s_param + QMC_SPE_ZDSTATE,
>   			    chan->mode == QMC_TRANSPARENT ?
>   				chan->qmc->data->zdstate_transp :
> @@ -980,6 +982,7 @@ static int qmc_chan_start_rx(struct qmc_chan *chan)
>   	}
>   
>   	/* Restart the receiver */
> +	qmc_write32(chan->s_param + QMC_SPE_RPACK, chan->qmc->data->rpack);
>   	qmc_write32(chan->s_param + QMC_SPE_ZDSTATE,
>   		    chan->mode == QMC_TRANSPARENT ?
>   			chan->qmc->data->zdstate_transp :
> @@ -1405,6 +1408,7 @@ static int qmc_setup_chan(struct qmc *qmc, struct qmc_chan *chan)
>   	qmc_write32(chan->s_param + QMC_SPE_TSTATE, chan->qmc->data->tstate);
>   	qmc_write32(chan->s_param + QMC_SPE_RSTATE, chan->qmc->data->rstate);
>   	qmc_write32(chan->s_param + QMC_SPE_ZISTATE, chan->qmc->data->zistate);
> +	qmc_write32(chan->s_param + QMC_SPE_RPACK, chan->qmc->data->rpack);
>   	if (chan->mode == QMC_TRANSPARENT) {
>   		qmc_write32(chan->s_param + QMC_SPE_ZDSTATE, chan->qmc->data->zdstate_transp);
>   		qmc_write16(chan->s_param + QMC_SPE_TMRBLR, 60);
> @@ -1544,6 +1548,8 @@ static void qmc_irq_gint(struct qmc *qmc)
>   			/* Restart the receiver if needed */
>   			spin_lock_irqsave(&chan->rx_lock, flags);
>   			if (chan->rx_pending && !chan->is_rx_stopped) {
> +				qmc_write32(chan->s_param + QMC_SPE_RPACK,
> +					    chan->qmc->data->rpack);
>   				qmc_write32(chan->s_param + QMC_SPE_ZDSTATE,
>   					    chan->mode == QMC_TRANSPARENT ?
>   						chan->qmc->data->zdstate_transp :
> @@ -1810,6 +1816,7 @@ static const struct qmc_data qmc_data_cpm1 = {
>   	.zistate = 0x00000100,
>   	.zdstate_hdlc = 0x00000080,
>   	.zdstate_transp = 0x18000080,
> +	.rpack = 0x00000000,
>   };
>   
>   static const struct of_device_id qmc_id_table[] = {