linux-kernel - Re: [PATCH v3] drivers:ras:Use IS_ERR() to check debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240823122557.GAZsh_1fb3lYpQ3zj1@fat_crate.local>
Date: Fri, 23 Aug 2024 14:25:57 +0200
From: Borislav Petkov <bp@...en8.de>
To: Yang Ruibin <11162571@...o.com>
Cc: Tony Luck <tony.luck@...el.com>, Ingo Molnar <mingo@...nel.org>,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	opensource.kernel@...o.com
Subject: Re: [PATCH v3] drivers:ras:Use IS_ERR() to check
 debugfs_create_dir() return value

On Fri, Aug 23, 2024 at 08:01:47PM +0800, Yang Ruibin wrote:
> The debugfs_create_dir() function returns error pointers.It
> never returns NULL. So use IS_ERR() to check its return value.
> 
> Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")

Nope, can't be that one:

$ git show 011d82611172:fs/debugfs/inode.c
...
struct dentry *debugfs_create_dir(const char *name, struct dentry *parent)
{
        struct dentry *dentry = start_creating(name, parent);
        struct inode *inode;

        if (IS_ERR(dentry))
                return NULL;
		       ^^^^


-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette