linux-kernel - Re: [PATCH net-next] net: thunderx: Remove unused declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240825081214.GV2164@kernel.org>
Date: Sun, 25 Aug 2024 09:12:14 +0100
From: Simon Horman <horms@...nel.org>
To: Yue Haibing <yuehaibing@...wei.com>
Cc: sgoutham@...vell.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: thunderx: Remove unused declarations

On Sat, Aug 24, 2024 at 04:27:54PM +0800, Yue Haibing wrote:
> Commit 4863dea3fab0 ("net: Adding support for Cavium ThunderX network
> controller") declared nicvf_qset_reg_{write,read}() but never implemented.
> 
> Commit 4863dea3fab0 ("net: Adding support for Cavium ThunderX network
> controller") declared bgx_add_dmac_addr() but no implementation.
> 
> After commit 5fc7cf179449 ("net: thunderx: Cleanup PHY probing code.")
> octeon_mdiobus_force_mod_depencency() is not used any more.

Maybe not so important, but perhaps it is worth mentioning that the
implementation of octeon_mdiobus_force_mod_depencency was subsequently
removed from the tree in commit 791e5f61aec5 ("net: phy: mdio-octeon:
Cleanup module loading dependencies").

> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>

I checked and all these symbols are indeed neither used nor implemented as
described above. And, my comment above notwithstanding, the cited commits
also look correct to me.

Reviewed-by: Simon Horman <horms@...nel.org>