linux-kernel - Re: [PATCH] staging: vme_user: Added static to image_desc and vme_user_vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240825081302.qBkqUqoK@linutronix.de>
Date: Sun, 25 Aug 2024 10:13:02 +0200
From: Nam Cao <namcao@...utronix.de>
To: Riyan Dhiman <riyandhiman14@...il.com>
Cc: gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: vme_user: Added static to image_desc and
 vme_user_vma_priv struct

On Sun, Aug 25, 2024 at 09:25:14AM +0530, Riyan Dhiman wrote:
> struct image_desc and vme_user_vma_priv are used only in vme_user.c file.
> Added keyword static to these struct definition to limit its scope and
> potentially allow for compiler optimizations.

I'm not sure if there is any optimization that compilers can do, when we
tell it that the struct definitions are local.

Did Gcc not complain when you compile this patch? Because it did for me..

Best regards,
Nam