linux-kernel - Re: [PATCH v3] arm64: dts: imx8mm-emtop-baseboard: Add Peripherals Support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240823-demonic-jolly-chital-fb4d61-mkl@pengutronix.de>
Date: Fri, 23 Aug 2024 14:36:47 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Tarang Raval <tarang.raval@...iconsignals.io>
Cc: shawnguo@...nel.org, krzk+dt@...nel.org, festevam@...il.com, 
	Rob Herring <robh@...nel.org>, Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org, 
	Sascha Hauer <s.hauer@...gutronix.de>, linux-kernel@...r.kernel.org, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3] arm64: dts: imx8mm-emtop-baseboard: Add Peripherals
 Support

On 23.08.2024 17:31:57, Tarang Raval wrote:
> Add following peripherals support for the Emtop i.MX8M Mini Baseboard
> 
> 	* Wi-Fi
> 	* Audio
> 	* SD card
> 	* RTC
> 	* CAN bus
> 	* USB OTG
> 
> Signed-off-by: Tarang Raval <tarang.raval@...iconsignals.io>
> ---
> 
> Changes in v2:
> 
> 1. Updated the node name and pinctrl name.
> 2. Removed the 'regulators' container.
> 3. Removed a stray blank line.
> 4. Removed non-existent properties.
> 5. Removed unused node and pinctrl:
>    -modem-reset
>    -pinctrl_uart1
> 6. Defined the CAN transceiver reset GPIO separately.
> 
> Change in v3:
> 
> 1. Removed 'can-connector'.
> 2. Use USB connector instead of extcon_usb.
> 3. Changed id-gpio to id-gpios.
> 4. Use Level trigger IRQ in the CAN node.
> 5. Corrected the compatible property of RTC.
> 6. Added blank lines to separate the pinctrl groups.
> ---
>  .../dts/freescale/imx8mm-emtop-baseboard.dts  | 326 ++++++++++++++++++
>  1 file changed, 326 insertions(+)

[...]

> +/* CAN BUS */
> +&ecspi2 {
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&pinctrl_ecspi2>;
> +        status = "okay";
> +
> +        can: can@0 {
> +                compatible = "microchip,mcp2515";
> +                reg = <0>;
> +                pinctrl-names = "default";
> +                pinctrl-0 = <&pinctrl_canbus>;
> +                clocks = <&osc_can>;
> +                interrupt-parent = <&gpio1>;
> +                interrupts = <14 IRQ_TYPE_LEVEL_HIGH>;

Have you actually tested this?
Previously there was: "interrupts = <14 IRQ_TYPE_EDGE_FALLING>;",
meaning the IRQ triggers on the edge "1 -> 0". It doesn't look correct,
if you say now there is an IRQ at level "1".

> +                spi-max-frequency = <10000000>;
> +        };
>  };

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)