linux-kernel - Re: [PATCH v3 1/2] Introduce klp_ops into klp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.2408252216300.12664@cbobk.fhfr.pm>
Date: Sun, 25 Aug 2024 22:17:39 +0200 (CEST)
From: Jiri Kosina <jikos@...nel.org>
To: zhang warden <zhangwarden@...il.com>
cc: Christoph Hellwig <hch@...radead.org>, 
    Josh Poimboeuf <jpoimboe@...nel.org>, Miroslav Benes <mbenes@...e.cz>, 
    pmladek@...e.com, joe.lawrence@...hat.com, live-patching@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] Introduce klp_ops into klp_func structure

On Sun, 25 Aug 2024, zhang warden wrote:

> >> 1. Move klp_ops into klp_func structure.
> >> Rewrite the logic of klp_find_ops and
> >> other logic to get klp_ops of a function.
> >> 
> >> 2. Move definition of struct klp_ops into
> >> include/linux/livepatch.h
> > 
> > Why?
> > 
> 
> Hi, Christoph.
> 
> When introducing feature of "using", we should handle the klp_ops check.
> In order to get klp_ops from transition, we may have more complex logic for 
> checking.
> 
> If we move klp_ops into klp_func. We can remove the global list head of klp_ops.
> What's more, there are some code in livepatch should get function's ops.
> With this feature, we don't need the original search to the one ops.
> It can be simple and straightforward.

I believe that Christoph's "Why?" in fact meant "please include the 
rationale for the changes being made (such as the above) in the patch 
changelog" :)

Thanks,

-- 
Jiri Kosina
SUSE Labs