linux-kernel - Re: [PATCH 1/2] memory: pl172: simplify releasing AMBA regions with devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44f42291-66c0-4b1e-a44c-221d31afae6f@mleia.com>
Date: Sun, 25 Aug 2024 23:19:11 +0300
From: Vladimir Zapolskiy <vz@...ia.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Krzysztof Kozlowski <krzk@...nel.org>,
 Miquel Raynal <miquel.raynal@...tlin.com>,
 Michal Simek <michal.simek@....com>, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Cc: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: [PATCH 1/2] memory: pl172: simplify releasing AMBA regions with
 devm

On 8/25/24 16:50, Krzysztof Kozlowski wrote:
> Use devm_add_action_or_reset() and dev_err_probe() to make the probe()
> error handling simpler around amba_release_regions() cleanup.  This
> allows to drop the remove() callback entirely.
> 
> Suggested-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Acked-by: Vladimir Zapolskiy <vz@...ia.com>
Reviewed-by: Vladimir Zapolskiy <vz@...ia.com>

--
Best wishes,
Vladimir