linux-kernel - Re: [PATCH v9 19/23] arch: arm64: dts: meson: gxl: correct crypto node definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240826135031.GA55751-robh@kernel.org>
Date: Mon, 26 Aug 2024 08:50:31 -0500
From: Rob Herring <robh@...nel.org>
To: Alexey Romanov <avromanov@...utedevices.com>
Cc: neil.armstrong@...aro.org, clabbe@...libre.com,
	herbert@...dor.apana.org.au, davem@...emloft.net,
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
	khilman@...libre.com, jbrunet@...libre.com,
	martin.blumenstingl@...glemail.com, vadim.fedorenko@...ux.dev,
	linux-crypto@...r.kernel.org, linux-amlogic@...ts.infradead.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, kernel@...utedevices.com
Subject: Re: [PATCH v9 19/23] arch: arm64: dts: meson: gxl: correct crypto
 node definition

On Tue, Aug 20, 2024 at 05:56:19PM +0300, Alexey Romanov wrote:
> GXL and newer SoC's uses the DMA engine (not blkmv) for crypto HW.
> Crypto HW doesn't actually use the blkmv clk. At RTL level, crypto
> engine is hard weired to clk81 (CLKID_CLK81). And remove clock-names
> field: according to the new dt-binding, it is no longer required.

Subject should be "arm64: dts: amlogic: ...". IIRC, Amlogic stuff has 
moved away from using "meson".

> 
> Also, GXL crypto IP isn't to seconnd interrput line. So we must
> remove it from dt-bindings.
> 
> Fixes: c4a0457eb858 ("ARM64: dts: amlogic: adds crypto hardware node")
> Signed-off-by: Alexey Romanov <avromanov@...utedevices.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> index 17bcfa4702e1..c29d5b81ce67 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> @@ -68,10 +68,8 @@ acodec: audio-controller@...32000 {
>  		crypto: crypto@...3e000 {
>  			compatible = "amlogic,gxl-crypto";
>  			reg = <0x0 0xc883e000 0x0 0x36>;
> -			interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>,
> -				     <GIC_SPI 189 IRQ_TYPE_EDGE_RISING>;
> -			clocks = <&clkc CLKID_BLKMV>;
> -			clock-names = "blkmv";
> +			interrupts = <GIC_SPI 188 IRQ_TYPE_EDGE_RISING>;
> +			clocks = <&clkc CLKID_CLK81>;
>  			status = "okay";
>  		};
>  	};
> -- 
> 2.34.1
>