linux-kernel - Re: [PATCH v9 17/23] dt-bindings: crypto: meson: correct clk and remove second interrupt line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <172468024695.61392.174903956615697419.robh@kernel.org>
Date: Mon, 26 Aug 2024 08:50:47 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Alexey Romanov <avromanov@...utedevices.com>
Cc: robh+dt@...nel.org, linux-crypto@...r.kernel.org, clabbe@...libre.com,
	neil.armstrong@...aro.org, jbrunet@...libre.com,
	martin.blumenstingl@...glemail.com, linux-kernel@...r.kernel.org,
	linux-amlogic@...ts.infradead.org, vadim.fedorenko@...ux.dev,
	linux-arm-kernel@...ts.infradead.org, kernel@...utedevices.com,
	krzysztof.kozlowski+dt@...aro.org, davem@...emloft.net,
	conor+dt@...nel.org, herbert@...dor.apana.org.au,
	devicetree@...r.kernel.org, khilman@...libre.com
Subject: Re: [PATCH v9 17/23] dt-bindings: crypto: meson: correct clk and
 remove second interrupt line


On Tue, 20 Aug 2024 17:56:17 +0300, Alexey Romanov wrote:
> GXL and newer SoC's uses the DMA engine (not blkmv) for crypto HW.
> Crypto HW doesn't actually use the blkmv clk. At RTL level, crypto
> engine is hard-wired to a clk81 (CLKID_CLK81). Drop clock-names
> field from schema: name "blkmv" is invalid and "clk81" is confusing
> and sounds like something global.
> 
> Also, GXL crypto IP isn't connected to the second interrupt line.
> This binding is useless, there are no users of this line.
> We must remove it from dt-bindings.
> 
> Fixes: 7f7d115dfb51 ("dt-bindings: crypto: Add DT bindings documentation for amlogic-crypto")
> Signed-off-by: Alexey Romanov <avromanov@...utedevices.com>
> ---
>  .../bindings/crypto/amlogic,gxl-crypto.yaml           | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>