[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <daaec2b0-0eaa-4a54-9cf9-70ad9aee34c7@oss.nxp.com>
Date: Mon, 26 Aug 2024 17:03:32 +0300
From: Andrei Stefanescu <andrei.stefanescu@....nxp.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Chester Lin <chester62515@...il.com>,
Matthias Brugger <mbrugger@...e.com>,
Ghennadi Procopciuc <Ghennadi.Procopciuc@....com>,
Larisa Grigore <larisa.grigore@....com>, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, NXP S32 Linux Team <s32@....com>
Subject: Re: [PATCH 2/3] drivers: gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs
support
Hi Linus,
On 26/08/2024 12:42, Linus Walleij wrote:
> Hi Andrei,
>
> thanks for your patch!
>
> On Mon, Aug 26, 2024 at 10:43 AM Andrei Stefanescu
> <andrei.stefanescu@....nxp.com> wrote:
>
Thank you for the quick review!
>
> As Krzysztof points out: the driver is based on something really old and
> needs an overhaul. Luckily GPIO drivers are not that big so it should be
> pretty straight-forward.
>
Are there other changes, apart from the ones in this email and those already
suggested by Krzysztof, that I should consider for v2?
I will fix the other comments in v2.
Best regards,
Andrei
Powered by blists - more mailing lists