linux-kernel - Re: [PATCH 2/3] drivers: gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d2fe7b0-f465-4f86-8cc9-5d413dba656b@kernel.org>
Date: Mon, 26 Aug 2024 16:04:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andrei Stefanescu <andrei.stefanescu@....nxp.com>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski
 <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Chester Lin <chester62515@...il.com>,
 Matthias Brugger <mbrugger@...e.com>,
 Ghennadi Procopciuc <Ghennadi.Procopciuc@....com>,
 Larisa Grigore <larisa.grigore@....com>
Cc: linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 NXP S32 Linux Team <s32@....com>
Subject: Re: [PATCH 2/3] drivers: gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs
 support

On 26/08/2024 16:03, Andrei Stefanescu wrote:
> Hi Krzysztof,
> 
> On 26/08/2024 12:10, Krzysztof Kozlowski wrote:
>> On 26/08/2024 10:42, Andrei Stefanescu wrote:
> 
> Thank you for the quick review!
> 
>>> +	raw_spin_lock_init(&gpio_dev->lock);
>>
>> Why do you use raw spin? Are you sure you need it (some people just
>> replace it thinking this will help them in PREEMPT_RT without actually
>> thinking if it is needed). IOW, do you have here irqchip anywhere?
> 
> I don't have an irqchip in this current patch series. There are, however,
> other patches which add support for interrupts and implementations for
> power management callbacks. I thought it would be easier for review if I
> sent those after the current series gets merged.

power management callbacks do not need raw spinlock.

> 
>>> +
>>> +static const struct of_device_id siul2_gpio_dt_ids[] = {
>>> +	{ .compatible = "nxp,s32g2-siul2-gpio", .data = &s32g2_device_data },
>>
>> Why do you have match data? There are no other variants.
> 
> 
> We do have another match data in our downstream version. Could I keep it
> here or should I remove it?

If you already work on new version and you are going to send it soon,
then it is fine. Otherwise you will add matchdata once there is such need.

Best regards,
Krzysztof