linux-kernel - Re: [PATCH v3 5/9] ethernet: cavium: Replace deprecated PCI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad6af1c4194873e803df65dc4d595f8e4b26cb33.camel@redhat.com>
Date: Mon, 26 Aug 2024 16:51:07 +0200
From: Philipp Stanner <pstanner@...hat.com>
To: Andy Shevchenko <andy@...nel.org>
Cc: Jonathan Corbet <corbet@....net>, Jens Axboe <axboe@...nel.dk>, Wu Hao
 <hao.wu@...el.com>, Tom Rix <trix@...hat.com>, Moritz Fischer
 <mdf@...nel.org>,  Xu Yilun <yilun.xu@...el.com>, Linus Walleij
 <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Alexandre
 Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>, Bjorn Helgaas
 <bhelgaas@...gle.com>, Alvaro Karsz <alvaro.karsz@...id-run.com>, "Michael
 S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>,  Eugenio Pérez
 <eperezma@...hat.com>, Richard Cochran <richardcochran@...il.com>, Mark
 Brown <broonie@...nel.org>, David Lechner <dlechner@...libre.com>, Uwe
 Kleine-König <u.kleine-koenig@...gutronix.de>, Damien Le
 Moal <dlemoal@...nel.org>,  Hannes Reinecke <hare@...e.de>, Chaitanya
 Kulkarni <kch@...dia.com>, linux-doc@...r.kernel.org, 
 linux-kernel@...r.kernel.org, linux-block@...r.kernel.org, 
 linux-fpga@...r.kernel.org, linux-gpio@...r.kernel.org,
 netdev@...r.kernel.org,  linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org,  linux-pci@...r.kernel.org,
 virtualization@...ts.linux.dev
Subject: Re: [PATCH v3 5/9] ethernet: cavium: Replace deprecated PCI
 functions

On Thu, 2024-08-22 at 17:44 +0300, Andy Shevchenko wrote:
> On Thu, Aug 22, 2024 at 03:47:37PM +0200, Philipp Stanner wrote:
> > pcim_iomap_regions() and pcim_iomap_table() have been deprecated by
> > the PCI subsystem in commit e354bb84a4c1 ("PCI: Deprecate
> > pcim_iomap_table(), pcim_iomap_regions_request_all()").
> > 
> > Replace these functions with the function pcim_iomap_region().
> 
> ...
> 
> > -	err = pcim_iomap_regions(pdev, 1 << PCI_PTP_BAR_NO,
> > pci_name(pdev));
> > -	if (err)
> > +	clock->reg_base = pcim_iomap_region(pdev, PCI_PTP_BAR_NO,
> > pci_name(pdev));
> > +	if (IS_ERR(clock->reg_base)) {
> > +		err = PTR_ERR(clock->reg_base);
> >  		goto error_free;
> > -
> > -	clock->reg_base = pcim_iomap_table(pdev)[PCI_PTP_BAR_NO];
> > +	}
> 
> Perhaps
> 
> 	clock->reg_base = pcim_iomap_region(pdev, PCI_PTP_BAR_NO,
> pci_name(pdev));
> 	err = PTR_ERR_OR_ZERO(clock->reg_base);
> 	if (err)
> 		goto error_free;
> 
> This will make your patch smaller and neater.
> 
> P.S. Do you use --histogram diff algo when preparing patches?

So far not.
Should one do that?

P.

>