linux-kernel - Re: [PATCH] clk: Delete redundant logic.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_728616623FAC3980B7FD8B7FC2F049031208@qq.com>
Date: Mon, 26 Aug 2024 22:45:25 +0800
From: jiping huang <huangjiping95@...com>
To: vladimir.zapolskiy@...aro.org
Cc: huangjiping95@...com,
	linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	mturquette@...libre.com,
	sboyd@...nel.org
Subject: Re: [PATCH] clk: Delete redundant logic.

  I'm very sorry, my submitted description may not have expressed it clearly. 
  Actually, it is, the local variable 'best_crent_rate' is only used in line 2355 \
for the judgment 'best_crent_rate!=parent ->rate'. However, if the \
"if (clk_core_can_round (core))" branch condition in line 2306 is true, \
the value of the local variable "best_crent_rate" will be updated by \
"best_crent_rate=req.best_crent_rate;" in line 2319, otherwise it will \
be directly returned in the "else if" branch in line 2325 and the "else" branch \
in line 2329. 
  In summary, it is unnecessary to store the "parent ->rate" value in "best_crent_rate" in line 2301.