linux-kernel - Re: [PATCH -fixes] drivers: perf: Fix smp_processor_id() use in preemptible code

Open Source and information security mailing list archives

Message-ID: <0e694f91-aaed-4412-a919-49779f37dabc@ghiti.fr>
Date: Mon, 26 Aug 2024 19:37:31 +0200
From: Alexandre Ghiti <alex@...ti.fr>
To: Nam Cao <namcao@...utronix.de>, Alexandre Ghiti <alexghiti@...osinc.com>
Cc: Atish Patra <atishp@...shpatra.org>, Anup Patel <anup@...infault.org>,
 Will Deacon <will@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 linux-riscv@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH -fixes] drivers: perf: Fix smp_processor_id() use in
 preemptible code

On 26/08/2024 19:31, Nam Cao wrote:
> On Mon, Aug 26, 2024 at 06:52:10PM +0200, Alexandre Ghiti wrote:
>> As reported in [1], the use of smp_processor_id() in
>> pmu_sbi_device_probe() must be protected by disabling the preemption, so
>> simple use get_cpu()/put_cpu() instead.
>>
>> Reported-by: Nam Cao <namcao@...utronix.de>
>> Closes: https://lore.kernel.org/linux-riscv/20240820074925.ReMKUPP3@linutronix.de/ [1]
>> Signed-off-by: Alexandre Ghiti <alexghiti@...osinc.com>
> Tested-by: Nam Cao <namcao@...utronix.de>
>
> I think this also needs:
> Fixes: a8625217a054 ("drivers/perf: riscv: Implement SBI PMU snapshot function")

Indeed, thanks for the tag!

>
> Best regards,
> Nam
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives