linux-kernel - Re: [PATCH v6] pktcdvd: Remove unnecessary debugfs_create_dir() error check in pkt_debugfs_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c698f351-5fdd-47c8-8450-54af72c7ad4c@kernel.dk>
Date: Mon, 26 Aug 2024 14:16:18 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Yang Ruibin <11162571@...o.com>, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: opensource.kernel@...o.com
Subject: Re: [PATCH v6] pktcdvd: Remove unnecessary debugfs_create_dir() error
 check in pkt_debugfs_dev_new()

On 8/26/24 12:26 AM, Yang Ruibin wrote:
> Remove the debugfs_create_dir() error check.
> It's safe to pass in errors that it gives you.

Please make it:

Remove the debugfs_create_dir() error check. It's safe to pass in error
pointers to the debugfs API, hence the user isn't supposed to include
error checking of the return values.

Note both the rewording, and that commit messages should be formatted to
72-74 char line lengths, not tiny ones.

-- 
Jens Axboe