linux-kernel - Re: [PATCH net-next v3 1/2] net: phy: Optimize phy speed mask to be compatible to yt8821

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cf3193b6-589f-41b7-b89a-a94ba3b751d8@motor-comm.com>
Date: Sun, 25 Aug 2024 22:56:54 -0700
From: "Frank.Sae" <Frank.Sae@...or-comm.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: hkallweit1@...il.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 yuanlai.cui@...or-comm.com, hua.sun@...or-comm.com,
 xiaoyong.li@...or-comm.com, suting.hu@...or-comm.com, jie.han@...or-comm.com
Subject: Re: [PATCH net-next v3 1/2] net: phy: Optimize phy speed mask to be
 compatible to yt8821


On 8/25/24 18:59, Andrew Lunn wrote:
> On Thu, Aug 22, 2024 at 04:47:00AM -0700, Frank Sae wrote:
>> yt8521 and yt8531s as Gigabit transceiver use bit15:14(bit9 reserved
>> default 0) as phy speed mask, yt8821 as 2.5G transceiver uses bit9 bit15:14
>> as phy speed mask.
>>
>> Be compatible to yt8821, reform phy speed mask and phy speed macro.
>>
>> Signed-off-by: Frank Sae <Frank.Sae@...or-comm.com>
>> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Ideally, your Signed-off-by: should be last. No need to repost because
> of this.
>
> 	Andrew

Andrew, please help to confirm that the Reviewed-by: should be followed by
Signed-off-by:?

it should be like below:
Reviewed-by: Andrew Lunn <andrew@...n.ch>
Signed-off-by: Frank Sae <Frank.Sae@...or-comm.com>

Best Regards