linux-kernel - Re: [PATCH net-next v3 2/2] net: phy: Add driver for Motorcomm yt8821 2.5G ethernet phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b64f3ec3-4497-4185-bea2-fdcb5f3f9403@lunn.ch>
Date: Mon, 26 Aug 2024 04:05:08 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Frank Sae <Frank.Sae@...or-comm.com>
Cc: hkallweit1@...il.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	yuanlai.cui@...or-comm.com, hua.sun@...or-comm.com,
	xiaoyong.li@...or-comm.com, suting.hu@...or-comm.com,
	jie.han@...or-comm.com
Subject: Re: [PATCH net-next v3 2/2] net: phy: Add driver for Motorcomm
 yt8821 2.5G ethernet phy

> +	ret = ytphy_modify_ext(phydev, YT8821_SDS_EXT_CSR_CTRL_REG, mask,
> +			       set);
> +	if (ret < 0)
> +		goto err_restore_page;
> +
> +err_restore_page:
> +	return phy_restore_page(phydev, old_page, ret);
> +}

> +
> +	ret = ytphy_modify_ext(phydev,
> +			       YT8821_UTP_EXT_DAC_IMSB_CH_0_1_CTRL_REG,
> +			       mask, set);
> +	if (ret < 0)
> +		goto err_restore_page;
> +
> +err_restore_page:
> +	return phy_restore_page(phydev, old_page, ret);
> +}

> +	ret = ytphy_modify_ext(phydev,
> +			       YT8521_EXTREG_SLEEP_CONTROL1_REG,
> +			       YT8521_ESC1R_SLEEP_SW,
> +			       enable ? 1 : 0);
> +	if (ret < 0)
> +		goto err_restore_page;
> +
> +err_restore_page:
> +	return phy_restore_page(phydev, old_page, ret);
> +}

Please could you remove all these pointless goto err_restore_page;

	Andrew