linux-kernel - Re: [PATCH] rtc: at91sam9: fix OF node leak in probe() error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <391cc2f7-4a88-4565-8653-e46bd77e28f8@linaro.org>
Date: Mon, 26 Aug 2024 08:59:17 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Markus Elfring <Markus.Elfring@....de>, linux-rtc@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Arnd Bergmann <arnd@...db.de>, Boris Brezillon <bbrezillon@...nel.org>,
 Claudiu Beznea <claudiu.beznea@...on.dev>, Johan Hovold <johan@...nel.org>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: at91sam9: fix OF node leak in probe() error path

On 25/08/2024 21:35, Markus Elfring wrote:
>> Driver is leaking an OF node reference obtained from
>> of_parse_phandle_with_fixed_args().
> 
> Is there a need to improve such a change description another bit?
> 
> + Imperative mood

I have enough of your stupid emails.

Commit msg is fine.

> 
> + Tags like “Fixes” and “Cc”

Read the patch.

PLONK.

Best regards,
Krzysztof