linux-kernel - Re: rtc: at91sam9: fix OF node leak in probe() error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bbc43cc6-0ee9-4cfd-b642-ac888ad9e627@web.de>
Date: Mon, 26 Aug 2024 09:12:32 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 linux-rtc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Arnd Bergmann <arnd@...db.de>, Boris Brezillon <bbrezillon@...nel.org>,
 Claudiu Beznea <claudiu.beznea@...on.dev>, Johan Hovold <johan@...nel.org>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: rtc: at91sam9: fix OF node leak in probe() error path

>>> Driver is leaking an OF node reference obtained from
>>> of_parse_phandle_with_fixed_args().
>>
>> Is there a need to improve such a change description another bit?
>>
>> + Imperative mood
…
> Commit msg is fine.
…
>> + Tags like “Fixes” and “Cc”
>
> Read the patch.

What does hinder you to take requirements from a known information source
better into account?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc5#n94

Regards,
Markus