linux-kernel - Re: rtc: at91sam9: fix OF node leak in probe() error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024082622-freckles-armored-978c@gregkh>
Date: Mon, 26 Aug 2024 09:30:30 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
	linux-rtc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	Arnd Bergmann <arnd@...db.de>,
	Boris Brezillon <bbrezillon@...nel.org>,
	Claudiu Beznea <claudiu.beznea@...on.dev>,
	Johan Hovold <johan@...nel.org>,
	Nicolas Ferre <nicolas.ferre@...rochip.com>, stable@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: rtc: at91sam9: fix OF node leak in probe() error path

On Mon, Aug 26, 2024 at 09:12:32AM +0200, Markus Elfring wrote:
> >>> Driver is leaking an OF node reference obtained from
> >>> of_parse_phandle_with_fixed_args().
> >>
> >> Is there a need to improve such a change description another bit?
> >>
> >> + Imperative mood
> …
> > Commit msg is fine.
> …
> >> + Tags like “Fixes” and “Cc”
> >
> > Read the patch.
> 
> What does hinder you to take requirements from a known information source
> better into account?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.11-rc5#n94
> 
> Regards,
> Markus
> 

Hi,

This is the semi-friendly patch-bot of Greg Kroah-Hartman.

Markus, you seem to have sent a nonsensical or otherwise pointless
review comment to a patch submission on a Linux kernel developer mailing
list.  I strongly suggest that you not do this anymore.  Please do not
bother developers who are actively working to produce patches and
features with comments that, in the end, are a waste of time.

Patch submitter, please ignore Markus's suggestion; you do not need to
follow it at all.  The person/bot/AI that sent it is being ignored by
almost all Linux kernel maintainers for having a persistent pattern of
behavior of producing distracting and pointless commentary, and
inability to adapt to feedback.  Please feel free to also ignore emails
from them.

thanks,

greg k-h's patch email bot