linux-kernel - Re: [PATCH 2/2] gpio: Add G7 Aspeed gpio controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42c569f4-9171-46e0-9df3-72c583106cc4@web.de>
Date: Mon, 26 Aug 2024 12:56:19 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Billy Tsai <billy_tsai@...eedtech.com>, linux-gpio@...r.kernel.org,
 devicetree@...r.kernel.org, linux-aspeed@...ts.ozlabs.org,
 BMC-SW@...eedtech.com, linux-arm-kernel@...ts.infradead.org,
 Andrew Jeffery <andrew@...econstruct.com.au>,
 Bartosz Golaszewski <brgl@...ev.pl>, Conor Dooley <conor+dt@...nel.org>,
 Joel Stanley <joel@....id.au>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Linus Walleij <linus.walleij@...aro.org>, Rob Herring <robh@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] gpio: Add G7 Aspeed gpio controller driver

…
> +++ b/drivers/gpio/gpio-aspeed-g7.c
> @@ -0,0 +1,831 @@
…
> +static void aspeed_gpio_g7_set(struct gpio_chip *gc, unsigned int offset, int val)
> +{
…
> +	raw_spin_lock_irqsave(&gpio->lock, flags);
> +
> +	__aspeed_gpio_g7_set(gc, offset, val);
> +
> +	raw_spin_unlock_irqrestore(&gpio->lock, flags);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(raw_spinlock_irqsave)(&gpio->lock);”?
https://elixir.bootlin.com/linux/v6.11-rc5/source/include/linux/spinlock.h#L551

Regards,
Markus