linux-kernel - Re: [PATCH 3/3] arm64: dts: imx93-11x11-evk: Enable sound-wm8962 sound card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86b80645-a11b-4875-a02e-e0b0c86a4f9d@kernel.org>
Date: Tue, 27 Aug 2024 15:27:07 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.Li@....com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Pengutronix Kernel Team <kernel@...gutronix.de>,
 Fabio Estevam <festevam@...il.com>,
 "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
 <devicetree@...r.kernel.org>,
 "open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <imx@...ts.linux.dev>,
 "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
 <linux-arm-kernel@...ts.infradead.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: imx93-11x11-evk: Enable sound-wm8962
 sound card

On 26/08/2024 22:53, Frank Li wrote:
> From: Chancel Liu <chancel.liu@....com>
> 
> Add wm8962 sound card which connects to sai3.

...

> +
>  &usbotg1 {
>  	dr_mode = "otg";
>  	hnp-disable;
> @@ -758,6 +816,26 @@ MX93_PAD_SD2_RESET_B__GPIO3_IO07	0x31e
>  		>;
>  	};
>  
> +	pinctrl_sai3: sai3grp {
> +		fsl,pins = <
> +			MX93_PAD_GPIO_IO26__SAI3_TX_SYNC                0x31e
> +			MX93_PAD_GPIO_IO16__SAI3_TX_BCLK                0x31e
> +			MX93_PAD_GPIO_IO17__SAI3_MCLK           0x31e
> +			MX93_PAD_GPIO_IO19__SAI3_TX_DATA00              0x31e
> +			MX93_PAD_GPIO_IO20__SAI3_RX_DATA00              0x31e
> +		>;
> +	};
> +
> +	pinctrl_sai3_sleep: sai3grpsleep {

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Best regards,
Krzysztof