[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zs3UrlufPJ9wVyep@smile.fi.intel.com>
Date: Tue, 27 Aug 2024 16:29:18 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Petr Mladek <pmladek@...e.com>, Steven Rostedt <rostedt@...dmis.org>,
Rasmus Villemoes <linux@...musvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@...omium.org>,
Jonathan Corbet <corbet@....net>,
John Ogness <john.ogness@...utronix.de>,
Andrew Morton <akpm@...ux-foundation.org>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] hexdump: Allow skipping identical lines
On Tue, Aug 27, 2024 at 11:01:47AM +0200, Miquel Raynal wrote:
> andriy.shevchenko@...ux.intel.com wrote on Mon, 26 Aug 2024 20:32:20
> +0300:
> > On Mon, Aug 26, 2024 at 06:24:14PM +0200, Miquel Raynal wrote:
...
> > Also here is the formal NAK till the series gains the test cases.
>
> What test cases are you talking about?
Anything meaningful you come up with to show that the printed data is
what it's expected. The module has a complimentary test case,
lib/test_hexdump.c. Without changes in that file, there is no go
to what ever golden ideas you have.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists