linux-kernel - Re: [PATCH RFC 0/3] Add generic Overlay for Grove Sunlight Sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b18cb162-e95c-4927-8fa7-1c29b8dda1a7@ti.com>
Date: Tue, 27 Aug 2024 10:22:18 -0500
From: Andrew Davis <afd@...com>
To: Ayush Singh <ayush@...gleboard.org>, Nishanth Menon <nm@...com>,
        Vignesh
 Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>, Rob Herring
	<robh+dt@...nel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vaishnav M A <vaishnav@...gleboard.org>,
        Derek
 Kiernan <derek.kiernan@....com>,
        Dragan Cvetic <dragan.cvetic@....com>, Arnd
 Bergmann <arnd@...db.de>,
        Michael Walle <mwalle@...nel.org>,
        Jason Kridner
	<jkridner@...gleboard.org>,
        Robert Nelson <robertcnelson@...gleboard.org>,
        Robert Nelson <robertcnelson@...il.com>,
        Ayush Singh
	<ayushdevel1325@...il.com>
CC: <linux-arm-kernel@...ts.infradead.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFC 0/3] Add generic Overlay for Grove Sunlight Sensor

On 8/27/24 8:20 AM, Ayush Singh wrote:
>> Sorry, no I've not had time to circle back to this for the last couple weeks,
>> and don't expect to be able to for a couple more :(
> 
> Np, I will see what I can do.
> 
> 
>>
>> The two parts I see that are missing are:
>>
>> 1) The /append-property/ tag [0].
> 
> So how do you envision it? Maybe something like the following:
> 
> Base:
> 
> / {
> 
>      node {
> 
>          prop = <0x00>;
> 
>      };
> 
> };
> 
> 
> Overlay:
> 
> &node {
> 
>      /append-property/ prop;
> 
>      prop = <0x01>;
> 
> };
> 
> 
> Or would it be better to append 1 element at a time, as follows:
> 
> &node {
> 
>      /append-property/ prop 0x01;
> 
> };
> 

Does

/append-property/ prop = <0x01 0x02 0x03>;

work? We will want to be able to append lists. Some type
checking will be needed, but shouldn't be too bad.

Probably good to get input from the DT folks which syntax
looks best to them.

> 
>>
>> 2) Allowing the __symbols__ table properties to be phandles, not just
>> full path strings.
>>
>> For item 2, this will make the "adapter overlays" look much nicer, but
>> more importantly allow chaining together adapters more easily.
>>
>> Both these changes will need to be made in the DTC project, then
>> moved back into kernel. Neither change breaks any existing compatibility
>> so I don't expect much resistance there. It just takes some time
>> to get changes in, then have them migrated to a kernel release before
>> we can make use of them.
>>
>> If you want to help with either of those two items (I can provide more
>> details if needed), that could help keep this moving along. :)
>>
>> Thanks,
>> Andrew
>>
>> [0] https://lkml.org/lkml/2024/7/5/311
> 
> 
> I am in the process of understanding the dtc codebase. Will send patches to device-tree mailing list since that seems to be easier to keep track of with the Linux patches instead of GitHub PRs.
> 

IIRC they have a dedicated mailing list for DTC,

devicetree-compiler@...r.kernel.org

Andrew

> 
> Ayush Singh
> 
>