linux-kernel - [PATCH] btrfs: qgroup: add missing extent changeset release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240827151243.63493-1-pchelkin@ispras.ru>
Date: Tue, 27 Aug 2024 18:12:43 +0300
From: Fedor Pchelkin <pchelkin@...ras.ru>
To: David Sterba <dsterba@...e.com>
Cc: Fedor Pchelkin <pchelkin@...ras.ru>,
	Chris Mason <clm@...com>,
	Josef Bacik <josef@...icpanda.com>,
	Boris Burkov <boris@....io>,
	linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	lvc-project@...uxtesting.org,
	syzbot+81670362c283f3dd889c@...kaller.appspotmail.com,
	stable@...r.kernel.org
Subject: [PATCH] btrfs: qgroup: add missing extent changeset release

The extent changeset may have some additional memory dynamically allocated
for ulist in result of clear_record_extent_bits() execution.

Release it after the local changeset is no longer needed in
BTRFS_QGROUP_MODE_DISABLED case.

Found by Linux Verification Center (linuxtesting.org) with Syzkaller.

Reported-by: syzbot+81670362c283f3dd889c@...kaller.appspotmail.com
Closes: https://lore.kernel.org/lkml/000000000000aa8c0c060ade165e@google.com
Fixes: af0e2aab3b70 ("btrfs: qgroup: flush reservations during quota disable")
Cc: stable@...r.kernel.org # 6.10+
Signed-off-by: Fedor Pchelkin <pchelkin@...ras.ru>
---
 fs/btrfs/qgroup.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index 5d57a285d59b..4f1fa5d427e1 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -4345,9 +4345,10 @@ static int __btrfs_qgroup_release_data(struct btrfs_inode *inode,
 
 	if (btrfs_qgroup_mode(inode->root->fs_info) == BTRFS_QGROUP_MODE_DISABLED) {
 		extent_changeset_init(&changeset);
-		return clear_record_extent_bits(&inode->io_tree, start,
-						start + len - 1,
-						EXTENT_QGROUP_RESERVED, &changeset);
+		ret = clear_record_extent_bits(&inode->io_tree, start,
+					       start + len - 1,
+					       EXTENT_QGROUP_RESERVED, &changeset);
+		goto out;
 	}
 
 	/* In release case, we shouldn't have @reserved */
-- 
2.39.2