linux-kernel - Re: [PATCH -next] md/raid1: cleanup local variable 'b' from radi1_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW6pKYcu5pN8PnQn_-d1ZT4PAtKHycFAs-3UfMueM1Lzhw@mail.gmail.com>
Date: Tue, 27 Aug 2024 10:10:01 -0700
From: Song Liu <song@...nel.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org, 
	yukuai3@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH -next] md/raid1: cleanup local variable 'b' from radi1_read_request()

On Thu, Aug 1, 2024 at 6:33 AM Yu Kuai <yukuai1@...weicloud.com> wrote:
>
> From: Yu Kuai <yukuai3@...wei.com>
>
> The local variable will only be used onced, in the error path that
> read_balance() failed to find a valid rdev to read. Since now the rdev
> is ensured can't be removed from conf while IO is still pending,
> remove the local variable and dereference rdev directly.
>
> Since we're here, also remove an extra empty line, and unnecessary
> type conversion from sector_t(u64) to unsigned long long.
>
> Signed-off-by: Yu Kuai <yukuai3@...wei.com>

Applied to md-6.12. Thanks!
Song